Use a RefSet, rather than a plain Object, for tracking already processed nodes in PartialEvaluator.hasBlendModes
#12099
Conversation
…PR 11680 follow-up) Given that this method is used during what's essentially a *pre*-parsing stage, before the actual OperatorList parsing occurs, on second thought it doesn't seem at all necessary to warn and trigger fallback in cases where there's lookup errors. *Please note:* Any any errors will still be either suppressed or thrown, according to the `ignoreErrors` option, during the *actual* OperatorList parsing.
…tialEvaluator.hasBlendModes` (PR 6971 follow-up) This case should no longer happen, given the `instanceof Ref` branch just above (added in PR 6971). Also, I've run the entire test-suite locally with `continue` replaced by `throw new Error(...)` and didn't find any problems.
…by using `for...of` loops - Replace the existing loops with `for...of` variants instead. - Make use of `continue`, to reduce indentation and to make the code (slightly) easier to follow, when checking `/Resources` entries.
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e2ba576cdeef343/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ffc251f863edf3e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/e2ba576cdeef343/output.txt Total script time: 26.63 mins
Image differences available at: http://54.67.70.0:8877/e2ba576cdeef343/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/ffc251f863edf3e/output.txt Total script time: 29.57 mins
Image differences available at: http://54.215.176.217:8877/ffc251f863edf3e/reftest-analyzer.html#web=eq.log |
…essed nodes in `PartialEvaluator.hasBlendModes`
Snuffleupagus
force-pushed
the
hasBlendModes-RefSet
branch
from
f419699 to
b348084
Compare
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e2c6a6a580b4c53/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/63ce9c3fe161b7c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/63ce9c3fe161b7c/output.txt Total script time: 26.60 mins
Image differences available at: http://54.67.70.0:8877/63ce9c3fe161b7c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/e2c6a6a580b4c53/output.txt Total script time: 30.63 mins
Image differences available at: http://54.215.176.217:8877/e2c6a6a580b4c53/reftest-analyzer.html#web=eq.log |
|
Thank you for improving this! |
No description provided.